Minor editor/world processor fixes and tweaks #10505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuken
reviewed
Feb 23, 2025
| @@ -1431,7 +1431,7 @@ public void run(LExecutor exec){ | |||
|
|
|||
| Team t = team.team(); | |||
|
|
|||
| if(type.obj() instanceof UnitType type && !type.internal && !type.hidden && t != null && Units.canCreate(t, type)){ | |||
| if(type.obj() instanceof UnitType type && t != null && Units.canCreate(t, type)){ | |||
There was a problem hiding this comment.
It is very important that internal units should not be spawned, as they could cause a crash.
There was a problem hiding this comment.
I know about this, as i stated in PR description, internal units still cannot be spawned because such global variables just don't exist.
But now i think this change still isn't worth it, because it won't go well in case someone decides to add some global vars, so i'll revert it.
upd: it still will be possible to spawn internal units by using setprop @payloadType (if they somehow appear in global vars), so i might change this as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trim()to newly typed spaces (it made starting a new word impossible without moving cursor to the middle)scrollXif there's not enough spacespawnunitable to spawn hidden units just likesetprop @payloadTypedoes (regarding the!type.internalremoval: internal units still can't be spawned because they're not in global processor vars)If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: